Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WordPress 6.7 Compatibility: Avoid block toolbar appearing when interacting custom product blocks #2670

Merged
merged 1 commit into from
Nov 12, 2024
Merged

WordPress 6.7 Compatibility: Avoid block toolbar appearing when interacting custom product blocks #2670

merged 1 commit into from
Nov 12, 2024

Conversation

eason9487
Copy link
Member

Changes proposed in this Pull Request:

With WordPress 6.7-RC3, block toolbars pop up unexpectedly when interacting with custom product blocks, and it also causes the E2E test to fail.

  • 1
  • 2
  • 3

This PR adds "__experimentalToolbar": false to all custom product blocks to prevent block toolbars from appearing.

Screenshots:

Kapture.2024-11-11.at.18.02.52.mp4

Detailed test instructions:

  1. Set up WordPress with 6.7-RC3
  2. Go to WooCommerce > Settings > Advanced > Features and enable "New product editor"
  3. Go to edit a product
  4. In the blockified product editor
    1. Switch to the "Google for WooCommerce" tab
    2. Interact with custom product blocks like Channel visibility, Condition, Availability Date, etc
    3. Check if the block toolbars won't appear
  5. View the successful E2E test run on GitHub Actions: https://github.com/woocommerce/google-listings-and-ads/actions/runs/11776255409/job/32798297581

Changelog entry

Fix - WordPress 6.7 Compatibility: Avoid the block toolbar appearing when interacting blockified product editor.

@eason9487 eason9487 requested a review from a team November 11, 2024 10:14
@eason9487 eason9487 self-assigned this Nov 11, 2024
@github-actions github-actions bot added type: bug The issue is a confirmed bug. changelog: fix Took care of something that wasn't working. labels Nov 11, 2024
mikkamp
mikkamp approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@mikkamp mikkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, I can confirm that the E2E tests pass locally after applying these changes.

image

Base automatically changed from dev/compat-wp-6-7-e2e-test to develop November 12, 2024 05:43
@eason9487 eason9487 merged commit e0b2e7c into develop Nov 12, 2024
5 checks passed
@eason9487 eason9487 deleted the fix/compat-wp-6-7-product-block-editor branch November 12, 2024 05:43
This was referenced Nov 12, 2024
Closed
Merged
@joemcgill joemcgill mentioned this pull request Nov 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikkamp mikkamp mikkamp approved these changes

Assignees

@eason9487 eason9487

Labels
changelog: fix Took care of something that wasn't working. type: bug The issue is a confirmed bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eason9487 @mikkamp